Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Update primaryDarker color to match VADS/USWDS updates #55

Merged
merged 4 commits into from
Dec 19, 2023
Merged

[Feature] Update primaryDarker color to match VADS/USWDS updates #55

merged 4 commits into from
Dec 19, 2023

Conversation

narin
Copy link
Contributor

@narin narin commented Dec 19, 2023 •
edited
Loading

Ticket #7371

Description of Change

VADS updated their primary colors to align with USWDS. So far, we've only brought in one colors that was updated, primaryDarker. This PR updates the HEX Code for primaryDarker.

Once we complete #7425, the rest of the colors will be brought into our repo.

image

Testing Packages

N/A

Screenshots/Video

N/A (Neither of our components are using this color)

Testing

N/A

PR Checklist

Code reviewer validation:

  • General
    • PR is linked to ticket(s)
    • PR has changelog label applied if it's to be included in the changelog
    • Acceptance criteria:
      • All satisfied or
      • Documented reason for not being performed or
      • Split to separate ticket and ticket is linked by relevant AC(s)
    • Above PR sections adequately filled out
    • If any breaking changes, in accordance with the pre-1.0.0 versioning guidelines: a CU ticket has been created for the VA Mobile App detailing necessary adjustments with the package version that will be published by this ticket
  • Code
    • Tests are included if appropriate (or split to separate ticket)
    • New functions have proper TSDoc annotations

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

@narin narin marked this pull request as ready for review December 19, 2023 16:43
@narin narin requested a review from a team as a code owner December 19, 2023 16:43
TimRoe
TimRoe approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@TimRoe TimRoe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but noting it is likely worth updating the ticket (not PR) to clarify for this point:

  • Acceptance criteria:
    • All satisfied or
    • Documented reason for not being performed or
    • Split to separate ticket and ticket is linked by relevant AC(s)

So one wouldn't need to dive into the comments looking back to realize most of the initial write-up wasn't completed with the ticket/was moved to another.

@narin
Copy link
Contributor Author

narin commented Dec 19, 2023

Approved, but noting it is likely worth updating the ticket (not PR) to clarify for this point:

  • Acceptance criteria:

    • All satisfied or
    • Documented reason for not being performed or
    • Split to separate ticket and ticket is linked by relevant AC(s)

So one wouldn't need to dive into the comments looking back to realize most of the initial write-up wasn't completed with the ticket/was moved to another.

Updated the ticket and noted for next time.

@narin narin merged commit 0adab6d into main Dec 19, 2023
4 of 6 checks passed
@narin narin deleted the feature/7371-narin-update-primary-colors branch December 27, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimRoe TimRoe TimRoe approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narin @TimRoe